PER-9866 [back-end] Endpoint for admins to update environment configu… #139
Conversation
iulianvsp
force-pushed
the
PER-9866
branch
2 times, most recently
from
d11149e to
285d3f2
Compare
| const validation = Joi.object() | ||
| .keys({ | ||
| ...fieldsFromAdminAuthentication, | ||
| description: Joi.string(), |
There was a problem hiding this comment.
description should be required here too, per the specification
There was a problem hiding this comment.
Ok, it seemed a bit odd not to be required on creation but required on update. I thought it's a documentation mistake.
There was a problem hiding this comment.
Oh, you're actually right, description can't be required because this endpoint needs to be able to set description to NULL by not sending it. Could you correct the error in the documentation so it matches the endpoint?
| @@ -283,3 +287,182 @@ describe("POST /feature-flag", () => { | |||
| expect(logger.error).toHaveBeenCalled(); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("PUT /feature-flag/1bdf2da6-026b-4e8e-9b57-a86b1817be5d", () => { | |||
There was a problem hiding this comment.
Nit: the URL param should be given as :featureFlagId here, rather than using a specific value
| description: 1, | ||
| globallyEnabled: true, | ||
| }) | ||
| .expect(400); |
There was a problem hiding this comment.
Should the error code here be 404?
There was a problem hiding this comment.
(I think the test is passing because it's not actually reaching the 404 error, it's getting a 400 because the ID in the URL params is not a UUID)
…ration New endpoint to update a feature-flag. There are validations on the globallyEnabled and description fields Unit and functional tests are covering all scenarios
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 91.08% 94.52% +3.43%
==========================================
Files 75 81 +6
Lines 1358 1497 +139
Branches 210 226 +16
==========================================
+ Hits 1237 1415 +178
+ Misses 110 75 -35
+ Partials 11 7 -4 ☔ View full report in Codecov by Sentry. |
…ration
New endpoint to update a feature-flag. There are validations on the globallyEnabled and description fields
Unit and functional tests are covering all scenarios