PER-9607 [back-end] Allow clearing a location #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianvsp
force-pushed
the
PER-9607-allow-clearing-a-location
branch
2 times, most recently
from
e09cdea to
d7c9886
Compare
liam-lloyd
reviewed
Nov 21, 2024
iulianvsp
force-pushed
the
PER-9607-allow-clearing-a-location
branch
4 times, most recently
from
8c3ce49 to
faa7dbd
Compare
liam-lloyd
reviewed
Nov 25, 2024
iulianvsp
force-pushed
the
PER-9607-allow-clearing-a-location
branch
2 times, most recently
from
bd7fc1e to
13beb09
Compare
liam-lloyd
reviewed
Nov 26, 2024
packages/api/src/record/service.ts
Outdated
| recordId: string, | ||
| recordData: PatchRecordRequest | ||
| ): Promise<string> => { | ||
| const dto = requestFieldsToDatabaseFields(recordData, recordId); |
There was a problem hiding this comment.
This should renamed now that the object assigned to this variable is not called a DTO.
iulianvsp
force-pushed
the
PER-9607-allow-clearing-a-location
branch
from
13beb09 to
c3d5f25
Compare
liam-lloyd
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.