Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electrumx Get Merkle Branch to bch-js #7

Open
christroutner opened this issue Jul 31, 2020 · 0 comments
Open

Add Electrumx Get Merkle Branch to bch-js #7

christroutner opened this issue Jul 31, 2020 · 0 comments

Comments

@christroutner
Copy link
Contributor

This task depends on this previous task being completed first.

The scope of this task is to add an Electrumx.merkleBranch() method to the Electrumx class in bch-js.

You should submit a PR to edit the electrumx.js file in bch-js to add this new merkleBranch method. Follow the same patterns in that file that is used for the utxo endpoint: It should accept a single txid or an array of txids.

Acceptance Criteria

  • Add an merkleBranch method to the Electrumx class in the electrumx.js file.
  • Add api-doc documentation and examples to the method in that file as well.
  • Add integration tests for both mainnet and testnet
  • Add unit tests with mocks.

You should be able to duplicate the patterns for the existing endpoints.

zh pushed a commit that referenced this issue Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant