[Core] Update stat rating to conversions

Pewtro · Aug 28, 2024 · 73419c0 · 73419c0
1 parent 5d7d9b9
commit 73419c0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/src/CHANGELOG.tsx b/src/CHANGELOG.tsx
@@ -35,6 +35,7 @@ import SpellLink from 'interface/SpellLink';
 
 // prettier-ignore
 export default [
+  change(date(2024, 8, 28), "Update rating to percentage conversions for stats for The War Within.", Putro),
   change(date(2024, 8, 25), 'Remove Redux reducer that stored the entire report under analysis.', ToppleTheNun),
   change(date(2024, 8, 22), 'Update Druid spells for Classic Cataclysm', jazminite),
   change(date(2024, 8, 13), 'Add patch 11.0.2.', ToppleTheNun),

diff --git a/src/parser/shared/modules/StatTracker.ts b/src/parser/shared/modules/StatTracker.ts
@@ -181,17 +181,17 @@ class StatTracker extends Analyzer {
     [SPELLS.MOUNTAINEER.id]: { versatility: 1.01 },
   };
 
-  //Values taken from https://github.com/simulationcraft/simc/blob/dragonflight/engine/dbc/generated/sc_scale_data.inc
+  //Values taken from https://github.com/simulationcraft/simc/blob/thewarwithin/engine/dbc/generated/sc_scale_data.inc
   statBaselineRatingPerPercent = {
     /** Secondaries */
-    [STAT.CRITICAL_STRIKE]: 180,
-    [STAT.HASTE]: 170,
-    [STAT.MASTERY]: 180,
-    [STAT.VERSATILITY]: 205,
+    [STAT.CRITICAL_STRIKE]: 700,
+    [STAT.HASTE]: 660,
+    [STAT.MASTERY]: 700,
+    [STAT.VERSATILITY]: 780,
     /** Tertiaries */
-    [STAT.AVOIDANCE]: 72,
-    [STAT.LEECH]: 148,
-    [STAT.SPEED]: 50,
+    [STAT.AVOIDANCE]: 544,
+    [STAT.LEECH]: 1020,
+    [STAT.SPEED]: 170,
   };
 
   // Values taken from https://github.com/wowsims/cata/blob/master/sim/core/base_stats_auto_gen.go
@@ -202,7 +202,7 @@ class StatTracker extends Analyzer {
   };
 
   /** Secondary stat scaling thresholds
-   * Taken from https://raw.githubusercontent.com/simulationcraft/simc/dragonflight/engine/dbc/generated/item_scaling.inc
+   * Taken from https://raw.githubusercontent.com/simulationcraft/simc/thewarwithin/engine/dbc/generated/item_scaling.inc
    * Search for 21024 in the first column for secondary stat scaling
    */
   secondaryStatPenaltyThresholds: PenaltyThreshold[] = [
@@ -218,13 +218,13 @@ class StatTracker extends Analyzer {
   ];
 
   /** Tertiary stat scaling thresholds
-   * Taken from https://raw.githubusercontent.com/simulationcraft/simc/dragonflight/engine/dbc/generated/item_scaling.inc
+   * Taken from https://raw.githubusercontent.com/simulationcraft/simc/thewarwithin/engine/dbc/generated/item_scaling.inc
    * Search for 21025 in the first column for tertiary stat scaling
    */
   tertiaryStatPenaltyThresholds: PenaltyThreshold[] = [
     /** Tertiary stat scaling thresholds */
     { base: 0, scaled: 0, penaltyAboveThis: 0 },
-    { base: 0.05, scaled: 0.05, penaltyAboveThis: 0 },
+    { base: 0.005, scaled: 0.05, penaltyAboveThis: 0 },
     { base: 0.1, scaled: 0.1, penaltyAboveThis: 0.2 },
     { base: 0.15, scaled: 0.14, penaltyAboveThis: 0.4 },
     { base: 0.2, scaled: 0.17, penaltyAboveThis: 0.6 },