Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrAPI: Fix ConnectionBuilder configuration #1069

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mobreza
Copy link
Contributor

@mobreza mobreza commented Nov 4, 2024

Description

Fixes issue where FieldBook indicates that http and https are supported, but then the OAuth AuthorizationService uses the built-in default with http disabled.

Type of change

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

Changelog entry

Improved support for BrAPI servers not using https

Fixes issue where FieldBook indicates that http and https are supported, but then AuthorizationService uses the default (with http disabled).
@trife trife requested a review from chaneylc November 4, 2024 17:24
@trife
Copy link
Member

trife commented Nov 27, 2024

@mobreza Apologies for the delay, we're working on finalizing a major release and will work on integrating these fixes into v6 over the next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants