Make the ChartXAxisRenderer more flexible: now possible to overwrite drawing the line or label of the ChartLimitLine #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the case "right bottom" the label is drawn at the wrong location
PhilJay
added a commit
that referenced
this pull request
Oct 4, 2015
|
|
|
Thanks for implementing the label offset In my Pull-Request there was also a refactoring included which made it possible to change how a limit line is actually rendererd. By extracting the rendering of one limit line (in XAxisRenderer) into its own method one can then override this method to provide a custom rendering of the limit line. |
regas99
pushed a commit
to regas99/MPAndroidChart
that referenced
this pull request
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Philipp
I have done a few refactorings of the ChartXAxisRenderer that allow the following:
It is now possible to extend the renderer and overwrite selectively the label or line drawing method for a ChartLimitLine (in my project I needed e.g. to draw a triangle as arrow at the top in one case or a short line at the bottom as well as change the label offset, now easily possible)
When not overriding these new methods it will do the same as before.
A corresponding pull-request for ios-charts has already been submitted by my colleague.
ChartsOrg/Charts#432
Thank you very much!
Best Regards
Ben