Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DefaultValueFormatter performance #5218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larryxiao625
Copy link

PR Checklist:

  • I have tested this extensively and it does not break any existing behavior.
  • I have added/updated examples and tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Improve DefaultValueFormatter performance

If the calculated number of digits has not changed, the DecimalFormat will not be reinitialized

As in #5217 describe, the DefaultValueFormatter will be calculated repeatedly and the DecimalFormat will be initialized. If there are a large number of icons on the interface, this will cause serious performance problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant