Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix after call setMinMaxScaleX, when scaleX to bound value, chart wil… #5391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renzhenfei
Copy link

@renzhenfei renzhenfei commented May 19, 2023

After call setMinMaxScaleX, when operate chart zoom, while scaleX or scaleY scale to max value or min value, the chart will jump.

PR Checklist:

  • I have tested this extensively and it does not break any existing behavior.
  • I have added/updated examples and tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]
    Line data chart jumps during zoom #4489

PR Description

In default BarLineChartTouchListener file, when handle zoom event, source code just post scaleX or scaleY, no check after call postScale the scaleX or scaleY value is valid.

This change limit scale to minScale or maxScale when zoom.

@hannesa2
Copy link
Contributor

hannesa2 commented Aug 3, 2023

Please can you show a before-this-change and a after-this-change screenshot ?

@hannesa2
Copy link
Contributor

hannesa2 commented Aug 3, 2023

It will probably merged here AppDevNext#138

@renzhenfei
Copy link
Author

renzhenfei commented Aug 7, 2023

@hannesa2
before

chart_before_cut.mp4

after

chart_after_cut.mp4

@hannesa2
Copy link
Contributor

hannesa2 commented Aug 7, 2023

@renzhenfei Thank you I'll merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants