Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #4334 where zoomAndCenterAnimated did not center #5433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SimonJackler
Copy link

@SimonJackler SimonJackler commented Dec 18, 2023

PR Checklist:

  • I have tested this extensively and it does not break any existing behavior.
  • I have added/updated examples and tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [zoomAndCenterAnimated not centering on x value #4334]

PR Description

Fixes issue with zoomAndCenterAnimated do not center but zooms to the start of the graph. See issue #4334

In static method AnimatedZoomJob:getInstance added the assignment of the parameters zoomCenterX, zoomCenterY, zoomOriginX, zoomOriginY.

This is a tiny fix to this excellent library. The solution was suggested 4 years ago but noone created a PR. Please merge so me and others don't have to compile from source.

…n coordinates.

In static method AnimatedZoomJob:getInstance added the assignment of the parameters zoomCenterX, zoomCenterY, zoomOriginX, zoomOriginY.
@hannesa2
Copy link
Contributor

hannesa2 commented Feb 1, 2024

While you wait for a merge (the last was 3 years ago), I merged it here already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants