Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lutris "Did not find any games" on recent update Boilr (1.9.2) #371

Closed
goofedup opened this issue Sep 19, 2023 · 13 comments · Fixed by #372
Closed

Lutris "Did not find any games" on recent update Boilr (1.9.2) #371

goofedup opened this issue Sep 19, 2023 · 13 comments · Fixed by #372
Labels
bug Something isn't working

Comments

@goofedup
Copy link

As title states after updating to 1.9.2 Boilr isn't finding any games under Lutris.

  • OS: Steam Deck
  • BoilR Version 1.9.2
@goofedup goofedup added the bug Something isn't working label Sep 19, 2023
@goofedup
Copy link
Author

Just wanted to confirm this is definitely related version 1.9.2. When downgrading to 1.9.1 everything works and games are found under Lutris.

@PhilipK
Copy link
Owner

PhilipK commented Sep 19, 2023

thanks for the report, just to make sure, is this with Lutris through flatpak or direct install? (I am assuming flatpak)

@goofedup
Copy link
Author

thanks for the report, just to make sure, is this with Lutris through flatpak or direct install? (I am assuming flatpak)

flatpak

@PhilipK
Copy link
Owner

PhilipK commented Sep 19, 2023

I have made a pre-release. It should solve the problem, can you confirm?
https://github.com/PhilipK/BoilR/releases/tag/v.1.9.3

(give it a couple of minutes to finish building, after I have posted this, the files should show up)

@goofedup
Copy link
Author

I have made a pre-release. It should solve the problem, can you confirm? https://github.com/PhilipK/BoilR/releases/tag/v.1.9.3

(give it a couple of minutes to finish building, after I have posted this, the files should show up)

The pre-release v.1.9.3 doesn't find any games in Lutris. I retested v.1.9.1 again just to confirm it works and it still does. If there's anything else I can send you to help figure things out let me know. It seems currently I'm the only one who is experiencing this issue so maybe it's something on my end? No idea. I'll just stick with v.1.9.1 for now.

@PhilipK
Copy link
Owner

PhilipK commented Sep 20, 2023 via email

@PhilipK
Copy link
Owner

PhilipK commented Sep 20, 2023 via email

@goofedup
Copy link
Author

Which version of lutris do you have?
0.5.13

Search installed only was checked. I unchecked it and tried importing and same result. On or off both have the same result of did not find any games.

@culain-45124
Copy link
Contributor

So sorry, this is my fault. I should have been clearer in my PR that this wouldn't work until a new version of Lutris is released as the new -a CLI option won't be present in the flatpak until then so queries will fail.

@PhilipK
Copy link
Owner

PhilipK commented Sep 22, 2023 via email

@PhilipK
Copy link
Owner

PhilipK commented Sep 22, 2023

@culain-45124 could I get you to test 1.93

@culain-45124
Copy link
Contributor

Yeah of course, I'll have a look this evening.

@culain-45124
Copy link
Contributor

Think I've found the issue in line 16 of src/platforms/lutris/lutris_game.rs. The details field isn't part of the original -ol json return.

I'll just test this and get a PR in, but feel free to beat me to it. Everything is grinding to a halt here

@culain-45124 culain-45124 mentioned this issue Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Commented out variables not common to both search types culain-45124/BoilR
3 participants
@PhilipK @goofedup @culain-45124