-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the potential redundant_clone issue of path #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR (and kind words), I have added a couple of comments and suggestions.
Thank you quick reply. Please take a look. |
Please take a look. |
I have no idea the reason it failed on Ubuntu and Flatpak. Please help me with this. Thanks. |
Hi @PhilipK , feel free to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem is that you need to add a /boilr
The unit test still seems to be failing |
Signed-off-by: Aisuko <urakiny@gmail.com>
I see. I updated the code. |
Signed-off-by: Aisuko urakiny@gmail.com
Hi @PhilipK , thanks for your work.
It is awesome. I fix a little bit potential issue for BoileR. I'm a big fan of Steam Deck, although my order was suspended in Canada.
Even though I cannot test it on my Steam Deck, I add a simple test case to support it does not change any useful feature. Here below,