Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the potential redundant_clone issue of path #238

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix the potential redundant_clone issue of path #238

merged 1 commit into from
Oct 4, 2022

Conversation

Aisuko
Copy link
Contributor

@Aisuko Aisuko commented Sep 27, 2022

Signed-off-by: Aisuko urakiny@gmail.com

Hi @PhilipK , thanks for your work.

It is awesome. I fix a little bit potential issue for BoileR. I'm a big fan of Steam Deck, although my order was suspended in Canada.

Even though I cannot test it on my Steam Deck, I add a simple test case to support it does not change any useful feature. Here below,

 *  Executing task: cargo test --package boilr --bin boilr -- config::tests::check_return_config_format --exact --nocapture 

   Compiling boilr v1.5.1 (/workspaces/BoilR)
    Finished test [unoptimized + debuginfo] target(s) in 28.74s
     Running unittests src/main.rs (target/debug/deps/boilr-23166f7cd679110a)

running 1 test
test config::tests::check_return_config_format ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 24 filtered out; finished in 0.00s

 *  Terminal will be reused by tasks, press any key to close it. 

Copy link
Owner

@PhilipK PhilipK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR (and kind words), I have added a couple of comments and suggestions.

src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@Aisuko
Copy link
Contributor Author

Aisuko commented Sep 27, 2022

Thank you quick reply. Please take a look.

src/config.rs Outdated Show resolved Hide resolved
@Aisuko
Copy link
Contributor Author

Aisuko commented Sep 27, 2022

Please take a look.

@Aisuko
Copy link
Contributor Author

Aisuko commented Sep 28, 2022

I have no idea the reason it failed on Ubuntu and Flatpak. Please help me with this. Thanks.

@Aisuko
Copy link
Contributor Author

Aisuko commented Oct 2, 2022

Hi @PhilipK , feel free to take a look.

Copy link
Owner

@PhilipK PhilipK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is that you need to add a /boilr

src/config.rs Outdated Show resolved Hide resolved
@Aisuko Aisuko requested a review from PhilipK October 3, 2022 05:37
@PhilipK
Copy link
Owner

PhilipK commented Oct 3, 2022

The unit test still seems to be failing

Signed-off-by: Aisuko <urakiny@gmail.com>
@Aisuko
Copy link
Contributor Author

Aisuko commented Oct 4, 2022

The unit test still seems to be failing

I see. I updated the code.

@PhilipK PhilipK merged commit 81e2110 into PhilipK:main Oct 4, 2022
@Aisuko Aisuko deleted the fix/redundantclone branch October 5, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants