Merge upstream cosmos-rust #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented `serde` traits for `Denom` - Changed internal `Coin` representation - Getter for `Decimal`'s internal value - Removed unused `Decimal`
Expose MsgGrantAllowance, MsgRevokeAllowance, BasicAllowance and AllowedMsgAllowance from cosmrs.
This includes the following additional dependency upgrades: - `k256` v0.11 - `ecdsa` v0.14
The re-exports CosmRS provides are easily overlooked, and many downstream users explicitly include `cosmrs`, `cosmos-sdk-proto`, and `tendermint` in their Cargo.toml. This documentation should help steer people towards using the re-exports.
Required by tendermint 0.23.8: cosmos#253
When trying to define an `osmosis-proto` crate (cosmos#239), we ran into the problem that it needed to import `cosmrs` to be able to impl the `MsgProto` trait. We couldn't follow the same pattern as `cosmrs` defining the type URLs for `cosmos-sdk-proto`, which it could only do because it defined the `MsgProto` trait as well. Knowledge of the type URLs is necessary to convert to/from `Any`, which Cosmos SDK uses all over the place. So far there isn't a good upstream solution to this problem in `prost` or AFAICT in `tendermint-proto` either. There's an upstream tracking issue for `prost` here: tokio-rs/prost#299 The ideal solution to this problem seems to be adding a `TYPE_URL` to `prost::Message`, and automatically populating them with `prost-build`. Failing that, this commit introduces a `TypeUrl` trait with an associated `TYPE_URL` const (previously provided by the `MsgProto` trait). The `from_any` and `to_any` methods have been moved to `MessageExt`.
Transitively enables gRPC support in `cosmos-sdk-proto`
This module contains only trait impls and is therefore empty. It was mistakenly made `pub`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update osmosis-proto branch