Feat: add support for docvalue_fields in TopHitsAggregation

Philippus · Oct 10, 2024 · 2363f4f · 2363f4f
1 parent 5c126aa
commit 2363f4f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...la/com/sksamuel/elastic4s/requests/searches/aggs/builders/TopHitsAggregationBuilder.scala b/...la/com/sksamuel/elastic4s/requests/searches/aggs/builders/TopHitsAggregationBuilder.scala
@@ -27,6 +27,9 @@ object TopHitsAggregationBuilder {
 
     agg.explain.foreach(builder.field("explain", _))
 
+    if (agg.storedFields.nonEmpty)
+      builder.array("docvalue_fields", agg.storedFields.toArray)
+
     agg.highlight.foreach { highlight =>
       builder.rawField("highlight", HighlightBuilderFn(highlight))
     }

diff --git a/...c/test/scala/com/sksamuel/elastic4s/requests/searches/TopHitsAggregationBuilderTest.scala b/...c/test/scala/com/sksamuel/elastic4s/requests/searches/TopHitsAggregationBuilderTest.scala
@@ -13,9 +13,10 @@ class TopHitsAggregationBuilderTest extends AnyFunSuite with Matchers {
       .from(10)
       .version(true)
       .explain(false)
+      .storedFields(List("name"))
       .sortBy(List(FieldSort("price").sortMode(SortMode.Median)))
     TopHitsAggregationBuilder(q).string shouldBe
-      """{"top_hits":{"size":5,"from":10,"sort":[{"price":{"mode":"median","order":"asc"}}],"explain":false,"version":true}}"""
+      """{"top_hits":{"size":5,"from":10,"sort":[{"price":{"mode":"median","order":"asc"}}],"explain":false,"docvalue_fields":["name"],"version":true}}"""
   }
 
   test("top hits aggregation builder should support highlighting") {