Merge DataProvider migration recipe from MBoegers/migrate-testngtojupiter-rewrite #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/io/github/mboegers/openrewrite/testngtojupiter/MigrateDataProvider.java
Show resolved
Hide resolved
src/main/java/io/github/mboegers/openrewrite/testngtojupiter/helper/AnnotationArguments.java
Outdated
Show resolved
Hide resolved
Philzen
force-pushed
the
6-dataprovider-migration
branch
from
ddc2016 to
594d745
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Philzen
force-pushed
the
6-dataprovider-migration
branch
from
cb9d3d3 to
f0ca1a0
Compare
|
Makes official org.openrewrite.java.testing.* recipes available for usage in our own master recipe.
Annotation type is J.FieldAccess anytime the annotation is fully qualified. The code in org.openrewrite.java.testing.junit5.UpdateTestAnnotation (which this is based on) would build a new annotation instance instead of modifying the type of the existing annotation. It turns out the latter also works fine for this recipe's scope.
Philzen
force-pushed
the
main
branch
30 times, most recently
from
d7e746f to
d606f71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.