Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customized] Extended gattling rate down logic #1469

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

CrimRecya
Copy link
Contributor

  • Now you can customize some effects of RateDown.
    • RateDown.Delay controls the delay before using RateDown to reduce the gattling value.
    • RateDown.Cover replaces the original RateDown when techno's ammo is lower than RateDown.Ammo.
    • RateDown.Reset controls whether to reset the gattling value directly when the techno has no target or changes targets.

In rulesmd.ini:

[SOMETECHNO]           ; TechnoType, `IsGattling=yes`
RateDown.Delay=0       ; integer, game frames
RateDown.Ammo=-2       ; integer
RateDown.Cover=0       ; integer
RateDown.Reset=false   ; boolean

Copy link

github-actions bot commented Dec 28, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Speederovsky
Copy link

This feature sounds useful, because RateDown.Reset would help fix certain issues with MO Crycopters, ie. maintaining deep freeze effect (high Gattling Stage) upon switching targets without moving the Cryocopter. It seems RateDown.Reset=yes mostly works, but there is a chance for a non-moving Cryocopter to maintain its high Gattling Stage effects for a two-three seconds after changing its target before it gets resets properly. Not sure what this is related to, it mostly resets the Rate properly.

@TaranDahl
Copy link
Contributor

This feature sounds useful, because RateDown.Reset would help fix certain issues with MO Crycopters, ie. maintaining deep freeze effect (high Gattling Stage) upon switching targets without moving the Cryocopter. It seems RateDown.Reset=yes mostly works, but there is a chance for a non-moving Cryocopter to maintain its high Gattling Stage effects for a two-three seconds after changing its target before it gets resets properly. Not sure what this is related to, it mostly resets the Rate properly.

看上去钩子被设置在Update的子函数UpdateFiring上,而尝试开火的操作在UpdateFiring之前被执行,这导致单位有可能在设置新目标后的一帧仍然以重置之前的加特林阶段开火。
It seems that the hook is set on the sub-function UpdateFiring of Update, and the operation of attempting to fire is executed before UpdateFiring. This causes the unit to possibly still fire in the Gatling stage before resetting in the frame after setting a new target.

@CrimRecya
Copy link
Contributor Author

This feature sounds useful, because RateDown.Reset would help fix certain issues with MO Crycopters, ie. maintaining deep freeze effect (high Gattling Stage) upon switching targets without moving the Cryocopter. It seems RateDown.Reset=yes mostly works, but there is a chance for a non-moving Cryocopter to maintain its high Gattling Stage effects for a two-three seconds after changing its target before it gets resets properly. Not sure what this is related to, it mostly resets the Rate properly.

Thanks for the feedback, I will fix it later.

@Speederovsky
Copy link

It seems to be resetting correctly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants