Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Basic Event Handler System #1486

Open
wants to merge 89 commits into
base: develop
Choose a base branch
from

Conversation

Aephiex
Copy link
Contributor

@Aephiex Aephiex commented Jan 1, 2025

The principles:

  1. The Event Handler system is meant to allow many highly customized effects in a straightforward and comprehensible way. It must not be complicated or confusing, and the resulting ini code must be highly readible.
  2. Various effects can be done with a simple weapon detonation. Such effects are not recommended to be added to the Event Handler system, unless doing in the other way is too complicated or not fairly straightforward, or is not able to affect some scopes that the modder may have been intended to (passengers for example).
  3. More pre-defined event calls are welcome, as they open up more possibility for general modding.

@Aephiex Aephiex marked this pull request as draft January 1, 2025 13:41
@Aephiex
Copy link
Contributor Author

Aephiex commented Jan 1, 2025

@Metadorius This is not fully ready yet, but what are your thoughts?

Copy link

github-actions bot commented Jan 1, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Aephiex
Copy link
Contributor Author

Aephiex commented Jan 1, 2025

Okay, it is now working as intended.

@Aephiex Aephiex marked this pull request as ready for review January 1, 2025 22:06
@mevitar
Copy link

mevitar commented Jan 2, 2025

Is this the reason for why you closed your recent branches? Putting everything into one system?
And so i presume weapon firing on being crushed will be handled through events now?

@Aephiex
Copy link
Contributor Author

Aephiex commented Jan 2, 2025

Is this the reason for why you closed your recent branches? Putting everything into one system? And so i presume weapon firing on being crushed will be handled through events now?

Yes, this one is more versatile and can do more than just the crushed weapon trigger, infiltrate weapon trigger, and so on, and this one is fairly straightforward and easy to use.

@Aephiex Aephiex marked this pull request as draft January 2, 2025 17:11
@Aephiex Aephiex marked this pull request as ready for review January 3, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants