Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Fix two issues of enhanced straight trajectory #1500

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

CrimRecya
Copy link
Contributor

Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@mevitar
Copy link

mevitar commented Jan 20, 2025

Trajectory.Straight.ProximityMedial=yes now fires properly at the projectile instead of the building.

And as i tested it i noticed that previous builds might have had issues with reading Bright= from the Trajectory.Straight.ProximityWarhead=, because right now i'm getting bright flashes of light each time the proximity fuse is triggered, and i don't remember them being there earlier.

Whether i simply didn't notice it or there was an actual bug that got fixed... it works fine now (in fact, other warhead effects, like AttachEffect, appear to work too).

@CrimRecya
Copy link
Contributor Author

Trajectory.Straight.ProximityMedial=yes now fires properly at the projectile instead of the building.

And as i tested it i noticed that previous builds might have had issues with reading Bright= from the Trajectory.Straight.ProximityWarhead=, because right now i'm getting bright flashes of light each time the proximity fuse is triggered, and i don't remember them being there earlier.

Whether i simply didn't notice it or there was an actual bug that got fixed... it works fine now (in fact, other warhead effects, like AttachEffect, appear to work too).

I didn't make any changes to the flash. Maybe it was not noticed at that time? Anyway, I will merge this repair. Thank you for your test.

@CrimRecya CrimRecya merged commit 5a9a0ef into Phobos-developers:develop Jan 20, 2025
4 of 7 checks passed
@CrimRecya CrimRecya deleted the develop-StraightFix branch January 20, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants