Optimize setting the data gpio bits #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2022 21:08
|
@akuker @nucleogenic I am missing the SonarCloud analysis for this PR. @nucleogenic Can it be that it got lost with one of your recent workflow changes? |
uweseimet
approved these changes
Dec 7, 2022
|
It looks like SonarCould ran for this. I can see the results as well: https://sonarcloud.io/summary/new_code?id=akuker_PISCSI&branch=akuker_fix_1019
|
|
@akuker I now also see them, but I had to click on "View details" first. Maybe something has changed in GitHub recently because before the results were always there. Anyway, I'm fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change significantly cuts down on the number of accesses to the GPIO control registers. Testing shows around 800% (8x) speed improvement with this change.
Note that this does not completely resolve #1019. It simply makes it better.
Max read speed is now 166KB/sec