Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow copy and move file operations to opt-in to overwrite. #1120

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Allow copy and move file operations to opt-in to overwrite. #1120

merged 3 commits into from
Mar 6, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Mar 5, 2023 •
edited
Loading

  • Allow create, copy and move file operations to opt-in to overwrite
  • Use this when extracting packaged properties to avoid it getting stuck in the images dir
  • Better error handling in common file operation methods

@rdmark rdmark requested a review from nucleogenic March 5, 2023 07:02
@rdmark rdmark mentioned this pull request Mar 5, 2023
Closed
nucleogenic
nucleogenic approved these changes Mar 5, 2023
View reviewed changes
python/common/src/piscsi/file_cmds.py Outdated Show resolved Hide resolved
@rdmark
Copy link
Member Author

rdmark commented Mar 6, 2023

@Pacjunk Please let us know if this resolves your problem. I made a simple test case for myself that passed.

@Pacjunk
Copy link
Contributor

Pacjunk commented Mar 6, 2023

@rdmark Seems to be OK. Thanks

@rdmark rdmark merged commit f5ac937 into develop Mar 6, 2023
@rdmark rdmark deleted the rdmark-issue-1118 branch March 6, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenic nucleogenic nucleogenic approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdmark @Pacjunk @nucleogenic