Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI: Create a system admin page and move options there #1222

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Sep 26, 2023

Create a new admin page with an entry point in the header

Remove system operations, system name, language, logging, log level from the index page. Remove theme, file sharing, macproxy from the footer. Put them all on the new admin page.

Added svg icons from the same set as the MIT licensed ones we're using now: https://github.com/feathericons/feather/tree/main/icons

@uweseimet
Copy link
Contributor

@rdmark I just noticed that for my current branches SonarCloud reports a new Python issue, which most likely appeared in my branch after merging the current develop branch into mine. https://sonarcloud.io/project/branches_list?id=akuker_PISCSI does not list any SonarCloud analysis for your current PRs, but only for other branches. Any idea why the SonarCloud data for your PRs seem to be missing?

@akuker
Copy link
Member

akuker commented Oct 1, 2023

I believe the security token expired for sonarcloud. (The last token was created in Sept 2023, so makes sense it would expire after a year) Working to fix it now....

@rdmark rdmark force-pushed the rdmark-issue-1218 branch 2 times, most recently from 0d3e314 to f046b06 Compare October 1, 2023 22:24
@rdmark
Copy link
Member Author

rdmark commented Oct 1, 2023

@uweseimet I rebased and force pushed this branch after @akuker 's bump to sonar v5 and the analysis ran and found two issues with the html code:

https://sonarcloud.io/summary/new_code?id=akuker_PISCSI&branch=rdmark-issue-1218

However it didn't report Python code quality issues so I'm not sure what happened in your branch?

@uweseimet
Copy link
Contributor

uweseimet commented Oct 1, 2023

@rdmark You can see the issue (code smell) on https://sonarcloud.io/summary/new_code?id=akuker-PISCSI&branch=issue_1182. The affected file has not been changed by me, but it is reported in my branch.
I wonder why there is no Python-related branch on https://sonarcloud.io/project/branches_list?id=akuker-PISCSI. Where are the branches you created the PRs for?

@rdmark
Copy link
Member Author

rdmark commented Oct 2, 2023

@uweseimet In this Sonar report I can see the one code smell for python/web/src/templates/base.html ... a fix for this has been force pushed to this PR.

Copy link

sonarcloud bot commented Nov 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rdmark
Copy link
Member Author

rdmark commented Nov 1, 2023

With some tweaks done to the CI workflow elsewhere, we now finally get Python static analysis reports for Python PRs.

The drawback is that Python the PR workflow now takes 11 minutes to complete.

@rdmark
Copy link
Member Author

rdmark commented Nov 1, 2023

@uweseimet This is the final code change for the clients that I want to make before the next release. After that I will rebase the translation updates PR and refresh it with machine translated strings.

Hopefully @nucleogenic will have a chance to look at it soon!

@rdmark
Copy link
Member Author

rdmark commented Nov 3, 2023

This PR has been tested and pending for a month now. I'm going to bypass the branch protection and merge this.

@rdmark rdmark merged commit e4c9b33 into develop Nov 3, 2023
9 of 10 checks passed
@rdmark rdmark deleted the rdmark-issue-1218 branch November 3, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants