Fix SonarQube issues #1276
Merged
Fix SonarQube issues #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uweseimet
requested review from
akuker,
erichelgeson and
rdmark
as code owners
|
Just added a fix for scsidump so that an error is reported when there is no target ID for INQUIRY. |
|
Kudos, SonarCloud Quality Gate passed! |
rdmark
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some new C++ SonarQube issues which have not been reported before. This PR fixes them.
@rdmark As far as I can tell there are also new Python issues reported for the develop branch. I recommend reviewing them before the release. Feel free to add any Python changes to the branch for this PR.