Web UI: Refactor file upload code to make it safer #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rdmark
commented
Nov 4, 2023
•
rdmark
commented
- Use Path objects to construct file upload paths
- Utility function for dir path validation (reduce cognitive complexity and code duplication)
- Construct subdir paths without leading "/" (reducing the risk of uploading to file system root)
- Break out inline literal list and turn it into tuple constant (for readability)
rdmark
force-pushed
the
rdmark-issue-1294
branch
from
3e1359f
to
7edf56b
Compare
|
SonarCloud Quality Gate failed.
|
nucleogenic
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.