Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk image profile management using a sidecar config file #242

Merged
merged 72 commits into from
Sep 19, 2021
Merged

Disk image profile management using a sidecar config file #242

merged 72 commits into from
Sep 19, 2021

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Sep 18, 2021

  • Disk profiles kept in src/web/sidecars.json in json format
  • New page that lists disk profiles and allows you to create image+sidecar pairs
  • Implements file creation/deletion using new protobuf interface
  • Fleshes out the Daynaport attaching UI

rdmark added 26 commits September 15, 2021 20:47
@rdmark
Handle a case where reserved ids on the Web UI side are not actually …
26bddaf 
…reserved on the backend side
@rdmark
Better error handling when no device is found in list_devices
b58d1af
@rdmark
Better warning message
917e37d
@rdmark
Tag message as error
9b26cba
@rdmark
Fix device_info
fd5fd24
@rdmark
Get reserved ids from the server instead of storing a client side sta…
a754017 
…te, which caused front and backend to get out of sync in certain cases.
@rdmark
Initial implementation of sidecar configuration reading and writing
fdcf336
@rdmark
Use bytes for drive image creation internally
8bbaa09
@rdmark
Add named drive section
cdaea01
@rdmark
Move header to base.html
4badf52
@rdmark
Create the disk profile list page
ac691b3
@rdmark
Make lists of HDDs, CDRs, and Removable drives
b6bf297
@rdmark
Implement disk image + sidecar creation
e348b31
@rdmark
Implement CD-ROM device sidecar creation method
de2b839
@rdmark
Add more device configurations
cd54fd0
@rdmark
Add disclaimer
b08162c
@rdmark
Hide URL if none is provided
85cd898
@rdmark
Merge branch 'feature_image_creation' into feature_sidecar
ed879c9
@rdmark
Make the web ui use the new protobuf parameter maps
4db7ca2
@rdmark
Merge branch 'feature_image_creation' into feature_sidecar
7979c53
@rdmark
Make daynaport attaching UI more flexible
72c839f
@rdmark
Use the protobuf interface to create image files
d1749b2
@rdmark
Use new create image method for the sidecar flow as well
6a218b7
@rdmark
Move file deletion logic to protobuf commands; Refactor saving/loadin…
3420527 
…g config files
@rdmark
Update disk image creation
ebf5c57
@rdmark
Fix error
db51fd7
@rdmark
Copy link
Member Author

rdmark commented Sep 18, 2021

Note that this includes changes from @uweseimet 's feature_image_creation branch. I will let him merge these changes to develop first, and then rebase my PR afterwards.

@rdmark rdmark mentioned this pull request Sep 18, 2021
Closed
@rdmark
Copy link
Member Author

rdmark commented Sep 19, 2021

@uweseimet @erichelgeson Note that I changed the generated properties file suffix to '.properties' from '.rascsi' to make it a bit clearer what the purpose of those files are. It won't read '.rascsi' files created by an earlier revision of this PR.

erichelgeson
erichelgeson approved these changes Sep 19, 2021
View reviewed changes
Copy link
Collaborator

@erichelgeson erichelgeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good.

@rdmark rdmark merged commit 15febd1 into develop Sep 19, 2021
@rdmark rdmark deleted the feature_sidecar branch September 19, 2021 21:29
@rdmark rdmark mentioned this pull request Sep 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichelgeson erichelgeson erichelgeson approved these changes

@uweseimet uweseimet Awaiting requested review from uweseimet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdmark @uweseimet @erichelgeson