Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Schematic PDF file and Step 3D model #726

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Conversation

akuker
Copy link
Member

@akuker akuker commented Mar 6, 2022

No description provided.

@akuker akuker requested a review from rdmark March 6, 2022 01:38
@rdmark
Copy link
Member

rdmark commented Mar 6, 2022

@akuker Does the pdf file have the same contents as the step file? IMHO pdf files aren't ideal for version control, and adds heft to anyone who clones the repo.

@akuker
Copy link
Member Author

akuker commented Mar 6, 2022

The PDF has the same contents as the Schematic. STEP is a 3D model of the board. Agree that adding a bunch of PDFs to the repo isn't the greatest idea. But, I think this provides value for folks who don't have KiCAD installed.

@rdmark
Copy link
Member

rdmark commented Mar 6, 2022

@akuker Is Kicad able to render into a version control friendly format, such as svg?

Not saying that svg would be more user friendly per se, but just exploring options. :)

@akuker
Copy link
Member Author

akuker commented Mar 14, 2022

@akuker Is Kicad able to render into a version control friendly format, such as svg?

@rdmark - not that I'm aware of. I've removed all of the PDFs from the git repo and added them to the wiki instead. Does that sound like a better solution?

@rdmark
Copy link
Member

rdmark commented Mar 14, 2022

@akuker Sorry for being difficult! Yes, keeping the pdfs in the wiki sounds like a good idea, at least for now. If it becomes a management overhead to keep source and wiki in sync, let's revert back to the old way of doing things...

BTW, one random thought I had is to look into if there are kicad to pdf Linux tools, to create something like a pdf generation script in the repo.

@akuker akuker merged commit f2aa2db into develop Mar 14, 2022
@akuker akuker deleted the feature_add_pdf_schematic branch March 14, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants