Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakup GPIOBUS #843

Merged
merged 14 commits into from
Sep 10, 2022
Merged

Breakup GPIOBUS #843

merged 14 commits into from
Sep 10, 2022

Conversation

akuker
Copy link
Member

@akuker akuker commented Sep 10, 2022

This is intended to separate the systimer class from gpiobus and to move the different board types to their own header files. There shouldn't be any functional changes.

I removed the -Wextra from the Makefile since it looks like we lost that change. Let me know if you think it needs to stay in there.

@akuker
Copy link
Member Author

akuker commented Sep 10, 2022

Note: there are other changes/improvements needed. This is just the initial PR to break things up. More changes will be coming

@uweseimet
Copy link
Contributor

@akuker Not sure what you mean with -Wextra. Currently it is part of the build process (this is why I found the compile-time issue on buster today), and it should stay in the Makefile, because our code compiles fine with it.

Copy link
Contributor

@uweseimet uweseimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, from my side. Please check my comment on -Wextra, please.

@akuker
Copy link
Member Author

akuker commented Sep 10, 2022

Approved, from my side. Please check my comment on -Wextra, please.

I added this back in. Thanks @uweseimet !

@akuker
Copy link
Member Author

akuker commented Sep 10, 2022

0cb6948 and 42178fb are identical now.

@uweseimet - would you mind taking a look at this again and make sure I didn't mess something up? I accidentally checked in a bunch of banana pi changes before I merged this PR :(

https://github.com/akuker/RASCSI/compare/0cb6948..42178fb

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 107 Code Smells

0.0% 0.0% Coverage
2.1% 2.1% Duplication

@uweseimet
Copy link
Contributor

@akuker I could not find anything obviously wrong. I don't think that anything bad can happen anyway, because essentially that is a code move and not a change, and I bet that if something was wrong, rascsi would not work at al anymorel, i.e. there is hardly any potential of missing anything hidden.

@akuker
Copy link
Member Author

akuker commented Sep 10, 2022

Thanks @uweseimet

@akuker akuker merged commit e64c2f7 into develop Sep 10, 2022
@akuker akuker deleted the feature_bpi branch September 10, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants