Added rascsi filter to limit logging to a particular device #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uweseimet
changed the title
uweseimet
changed the title
uweseimet
requested review from
akuker,
erichelgeson and
rdmark
as code owners
akuker
reviewed
Nov 10, 2022
cpp/devices/device.cpp
Outdated
| @@ -146,3 +145,38 @@ bool Device::Eject(bool force) | |||
|
|
|||
| return true; | |||
| } | |||
|
|
|||
| void Device::LogTrace(const string& error) const | |||
There was a problem hiding this comment.
Could we come up with a different name? I think it could be confusing to have "LogTrace" and "LOGTRACE". Its not immediately obvious what the difference is.
There was a problem hiding this comment.
I agree with what you say, but I did not know better names. But anyway, by introducing the new DeviceLogger class this issue is resolved, and using a logger object is a better approach in other respects as well. It is now also used by the controller.
akuker
reviewed
Nov 10, 2022
|
Ready for review again |
|
Kudos, SonarCloud Quality Gate passed! |
akuker
approved these changes
Nov 11, 2022
|
@uweseimet - Ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added more unit tests, resolved SonarQube issues, improved code sharing, improved the error handling of the parser and fixed #979.