-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rascsi filter to limit logging to a particular device #978
Conversation
cpp/devices/device.cpp
Outdated
@@ -146,3 +145,38 @@ bool Device::Eject(bool force) | |||
|
|||
return true; | |||
} | |||
|
|||
void Device::LogTrace(const string& error) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we come up with a different name? I think it could be confusing to have "LogTrace" and "LOGTRACE". Its not immediately obvious what the difference is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with what you say, but I did not know better names. But anyway, by introducing the new DeviceLogger class this issue is resolved, and using a logger object is a better approach in other respects as well. It is now also used by the controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thx!
Ready for review again |
Kudos, SonarCloud Quality Gate passed! |
@uweseimet - Ready to merge! |
Also added more unit tests, resolved SonarQube issues, improved code sharing, improved the error handling of the parser and fixed #979.