Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiMove support #7

Merged
merged 16 commits into from
Apr 1, 2022

Conversation

stephanie-eng
Copy link
Contributor

@stephanie-eng stephanie-eng commented Mar 23, 2022

Switches from using abblibegm's EGMControllerInterface to abb_egm_rws_manager's egmManager to get support for multiple mechanical unit groups.

Fixes #2

@stephanie-eng stephanie-eng force-pushed the seng/egm_manager branch 3 times, most recently from 133a779 to 9293626 Compare March 23, 2022 22:01
@stephanie-eng stephanie-eng force-pushed the seng/egm_manager branch 4 times, most recently from 1eae914 to 55ac3cd Compare March 24, 2022 22:07
@stephanie-eng stephanie-eng changed the title WIP: Add MultiMove support Add MultiMove support Mar 25, 2022
@stephanie-eng stephanie-eng marked this pull request as ready for review March 25, 2022 13:27
@stephanie-eng stephanie-eng requested a review from AndyZe March 25, 2022 13:27
abb.repos Outdated Show resolved Hide resolved
docs/README.md Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
abb_hardware_interface/src/abb_system_position_only.cpp Outdated Show resolved Hide resolved
abb_hardware_interface/src/abb_system_position_only.cpp Outdated Show resolved Hide resolved
abb_hardware_interface/src/abb_system_position_only.cpp Outdated Show resolved Hide resolved
abb_hardware_interface/src/abb_system_position_only.cpp Outdated Show resolved Hide resolved
@@ -17,7 +17,7 @@
<depend>hardware_interface</depend>
<depend>pluginlib</depend>
<depend>rclcpp</depend>
<depend>abb_libegm</depend>
<depend>abb_egm_rws_managers</depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need abb_libegm, right?

(Please alphabetize, too)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer use abb_libegm directly, we get that functionality via abb_egm_rws_managers (which depends on abb_libegm)

@stephanie-eng stephanie-eng force-pushed the seng/egm_manager branch 5 times, most recently from ddac0e7 to c0e2fd8 Compare March 30, 2022 20:29
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming you make the small changes above ^

stephanie-eng and others added 2 commits April 1, 2022 13:58
Co-authored-by: AndyZe <andyz@utexas.edu>
Co-authored-by: AndyZe <andyz@utexas.edu>
@stephanie-eng stephanie-eng merged commit c044711 into PickNikRobotics:rolling Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to integrate an external axis?
3 participants