Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper selection of the name identifier during method renaming with SuggestedFixes#renameMethod #63

Closed
wants to merge 2 commits into from

Conversation

oxkitsune
Copy link

By asserting, the identifier token position is after the end position of the return type identifier.

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, resolved conflict and added a small commit.

Suggested commit message:

Prevent `SuggestedFixes#renameMethod` from modifying return type declaration

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's open a PR upstream 😄.

@oxkitsune oxkitsune force-pushed the gdejong/bug-method-name branch 2 times, most recently from 8a2a4f8 to 75e8ef5 Compare August 9, 2023 09:43
@oxkitsune
Copy link
Author

Upstream PR: google#4043

@Stephan202
Copy link
Member

Upstream PR merged!

@Stephan202 Stephan202 closed this Aug 10, 2023
@Stephan202 Stephan202 deleted the gdejong/bug-method-name branch August 10, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants