Consider avoiding the use of a pre-sized builder for the `FilteredCol…

…lection` and `FilteredMultimapValues` in `Maps#uniqueIndex`
PicnicSupermarket · Jul 14, 2023 · 51ec4e9 · 51ec4e9
1 parent cd0069a
commit 51ec4e9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/guava/src/com/google/common/collect/Maps.java b/guava/src/com/google/common/collect/Maps.java
@@ -35,6 +35,7 @@
 import com.google.common.base.Preconditions;
 import com.google.common.base.Predicate;
 import com.google.common.base.Predicates;
+import com.google.common.collect.Collections2.FilteredCollection;
 import com.google.common.collect.MapDifference.ValueDifference;
 import com.google.common.primitives.Ints;
 import com.google.errorprone.annotations.CanIgnoreReturnValue;
@@ -1325,7 +1326,8 @@ public static <K, V> ImmutableMap<K, V> toMap(
   @CanIgnoreReturnValue
   public static <K, V> ImmutableMap<K, V> uniqueIndex(
       Iterable<V> values, Function<? super V, K> keyFunction) {
-    if (values instanceof Collection) {
+    if (values instanceof Collection
+        && !(values instanceof FilteredCollection || values instanceof FilteredMultimapValues)) {
       return uniqueIndex(
           values.iterator(),
           keyFunction,