Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider avoiding the use of a pre-sized builder for the FilteredCollection and FilteredMultimapValues in Maps#uniqueIndex #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oksana-evs
Copy link

The PR to address this issue: google#6638

…lection` and `FilteredMultimapValues` in `Maps#uniqueIndex`
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could offer to open this PR against the upstream repository. For completeness we should then make the equivalent change to android/guava/src/com/google/common/collect/Maps.java.

That said, the Guava maintainers generally discourage opening PRs without prior discussion, unless the change is "obvious". In this case they could also opt to revert the builderWithExpectedSize change. So what we could do instead, is refer to this PR in a comment on google#6638, and ask whether they'd accept such a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants