Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional properties to GiftcardProgram #35

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

freerkminnema
Copy link
Contributor

Not all available GiftcardProgram properties are mapped yet. This PR adds:

  • max_amount_in_cents (?int)
  • calculator_flow (?string)
  • expiration_days (?int)

@iDiegoNL
Copy link
Member

iDiegoNL commented Oct 3, 2024

Thanks a lot for your pull request!

Before I merge this, can you add these new properties to the Piggy\Api\Tests\OAuth\GiftcardProgramsResourceTest as well?

@iDiegoNL iDiegoNL merged commit a8f8de7 into Piggy-Loyalty:master Oct 3, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants