Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

pass rviz config file path as launch argument #84

Closed
wants to merge 1 commit into from

Conversation

jschleicher
Copy link
Contributor

According to @rfeistenauer it is preferred to hava a rviz-config in
an application package and not just a user-default.
(See moveit/moveit#1397)

Re-generated demo.launch from upstream template.

Copy link
Contributor

@ct2034 ct2034 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of params handed through launch files should be consistent (i.e. rviz_config != rviz_config_file)

@ct2034 ct2034 self-assigned this Mar 20, 2019
According to @rfeistenauer it is preferred to hava a rviz-config in
an application package and not just a user-default.
(See moveit/moveit#1397)

Re-generated demo.launch from upstream template.
@jschleicher jschleicher force-pushed the feature/launch-args2 branch from e36521c to 2a7acfa Compare March 20, 2019 14:18
@jschleicher jschleicher requested a review from ct2034 March 20, 2019 14:25
Copy link
Contributor

@ct2034 ct2034 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That is what I needed 😄

@ct2034 ct2034 closed this Mar 20, 2019
@ct2034 ct2034 deleted the feature/launch-args2 branch March 20, 2019 15:28
@jschleicher jschleicher mentioned this pull request Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants