Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade go1.22 for tidb #2805

Closed
wants to merge 3 commits into from
Closed

Conversation

hawkingrei
Copy link
Contributor

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

ti-chi-bot bot commented Feb 19, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request upgrades the go version from 1.21 to 1.22 for tidb, and updates the corresponding images in the pipelines.

There are no potential problems with this pull request.

Suggestion: It is recommended to update the pull request description with more information, such as the reason for the upgrade and any potential impact on the system.

@ti-chi-bot ti-chi-bot bot requested a review from jayl1e February 19, 2024 00:59
@ti-chi-bot ti-chi-bot bot requested a review from purelind February 19, 2024 00:59
@ti-chi-bot ti-chi-bot bot added the size/S label Feb 19, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request updates the Go version used in the Tidb project. The image tag for the golang container is changed from hub.pingcap.net/wangweizhen/tidb_image:go12120230809 to hub.pingcap.net/wangweizhen/tidb_image:go122020240219.

There doesn't seem to be any potential problems with this change, as it is an upgrade to a newer version of Go. However, it would be good to make sure that all of the tests still pass after this upgrade.

One possible suggestion for improvement would be to add a brief explanation of the benefits of upgrading to Go 1.22, such as new features or performance improvements. This would help to provide context for the change and make it clearer why it is being made.

@wuhuizuo wuhuizuo force-pushed the main branch 2 times, most recently from e7af6d3 to 7685454 Compare February 29, 2024 12:12
Copy link

ti-chi-bot bot commented Mar 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the diff, it seems that the PR upgrades the Go version used in the tidb project. The image field in several YAML files under the pipelines/pingcap/tidb/latest/ directory are updated from go12120230809 to go122120240306.

There are no glaring issues with this PR, as it is a straightforward version upgrade. However, it's always a good idea to test the changes locally to ensure that everything still works as expected.

For fixing suggestions, it would be helpful if the PR description included more information about why the upgrade was necessary and what changes users can expect. Additionally, it would be useful to include any testing or benchmark results to demonstrate that the upgrade did not introduce any performance regressions.

Copy link

ti-chi-bot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign purelind for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wuhuizuo
Copy link
Collaborator

/hold
We should consider it after TiDB v8.1.0 released.

@wuhuizuo
Copy link
Collaborator

wuhuizuo commented Sep 4, 2024

/close

consider to upgrade to v1.23.x or 1.24.x (the "x" greater than 0) in TiDB v8.6+

@wuhuizuo wuhuizuo closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants