-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: upgrade go1.22 for tidb #2805
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
There are no potential problems with this pull request. Suggestion: It is recommended to update the pull request description with more information, such as the reason for the upgrade and any potential impact on the system. |
There doesn't seem to be any potential problems with this change, as it is an upgrade to a newer version of Go. However, it would be good to make sure that all of the tests still pass after this upgrade. One possible suggestion for improvement would be to add a brief explanation of the benefits of upgrading to Go 1.22, such as new features or performance improvements. This would help to provide context for the change and make it clearer why it is being made. |
e7af6d3
to
7685454
Compare
Based on the diff, it seems that the PR upgrades the Go version used in the There are no glaring issues with this PR, as it is a straightforward version upgrade. However, it's always a good idea to test the changes locally to ensure that everything still works as expected. For fixing suggestions, it would be helpful if the PR description included more information about why the upgrade was necessary and what changes users can expect. Additionally, it would be useful to include any testing or benchmark results to demonstrate that the upgrade did not introduce any performance regressions. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/close consider to upgrade to v1.23.x or 1.24.x (the "x" greater than 0) in TiDB v8.6+ |
ref pingcap/tidb#50765