Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publisher/pkg/impl): call Seek before upload the content to ks3 #190

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Nov 4, 2024

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from purelind November 4, 2024 04:08
Copy link

ti-chi-bot bot commented Nov 4, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and the diff, it seems that the change is fixing an issue related to uploading content to KS3. The change adds a call to Seek function before uploading the content to KS3. This ensures that the file pointer is reset to the beginning of the file, which was not happening previously.

There are no potential problems with this change. However, it is always a good practice to thoroughly test the code after making changes to ensure that everything is working as expected.

As for the suggestions, it would be better to add more details to the PR description, such as the problem that was being fixed and why this change was necessary. Also, it would be helpful to include any testing that was done to verify that the fix works as expected.

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 4, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Nov 4, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0ef76a1 into main Nov 4, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/implement-fs-upload-ks3 branch November 4, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant