Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/triggers): fix trigger git-push-pingcap-qe-artifacts #1115

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

…-qe-artifacts`

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind April 23, 2024 01:32
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Apr 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the provided information, it seems that the pull request is a fix for a trigger in the PingCAP-QE artifacts Tekton configuration. The changes to the git-push.yaml file involve adding a URL and echo statement, which will print the URL to the console.

One potential problem is that the changes do not seem to actually fix the trigger as described in the pull request title. The changes only add an echo statement that prints out the URL.

To fix the trigger, it might be necessary to add additional changes to the code. Without knowing the specifics of the issue, it is difficult to provide specific suggestions for fixing the trigger. Therefore, it is recommended that the author of the pull request provide more information about what the issue is and how the changes address the issue.

In addition, it would be helpful if the pull request description provided more context and information about the changes being made.

@ti-chi-bot ti-chi-bot bot added the size/XS label Apr 23, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit e2cd279 into main Apr 23, 2024
3 of 4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/git-push-pingcap-qe-artifacts-trigger branch April 23, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant