Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/harbor/release): try to solve uploading issue with chunksize param #1166

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

…nksize` param

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind June 17, 2024 07:08
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Jun 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 17, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that the change only adds a new parameter chunksize to the harbor release YAML file with a hard-coded value of 5242880. This parameter is related to uploading files to the KS3 region and can be used to specify the size of the chunks to upload.

The diff shows that only one line has been added to the release.yaml file in the harbor directory. This change is not complex and seems to be straightforward.

However, there could be some potential problems with this change. The hard-coded value of 5242880 may not be suitable for all scenarios, and it could lead to performance degradation or even failure if the chunk size is too small or too large. It would be better to make this value configurable or to use a more intelligent approach to determine the optimal chunk size based on the file size and network conditions.

To fix this, I would suggest adding a comment to explain the reason for the chunksize parameter and recommending that users adjust its value according to their specific needs. Additionally, it would be good to add some documentation about this parameter to the project's README file or the documentation website. Finally, it would be better to make the chunk size configurable, either by adding it to the application's configuration file or by adding a command-line flag to set it at runtime.

@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot ti-chi-bot bot added the size/XS label Jun 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit c06f132 into main Jun 17, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/harbor-chunksize branch June 17, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant