Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/triggers): disable tiflash mac target builds #1168

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

…ilds

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind June 25, 2024 09:43
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Jun 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, it looks like the changes are focused on disabling tiflash mac target builds. The changes made were altering the value of the "filter on repo and branches" parameter in the git-push-on-fips-branches.yaml file, and commenting out the ref line in the git-push.yaml file.

However, there are a few potential problems with this pull request. First, it's not clear why tiflash mac target builds need to be disabled. Secondly, commenting out the ref line in the git-push.yaml file might have unintended consequences that the submitter hasn't considered. Finally, the new value of the "filter on repo and branches" parameter in the git-push-on-fips-branches.yaml file is not formatted correctly.

To fix these issues, the submitter needs to add a more detailed explanation for why tiflash mac target builds need to be disabled. They should also consider whether commenting out the ref line in the git-push.yaml file is the best solution, or if there is another way to achieve the desired result. Finally, they should fix the formatting of the new value of the "filter on repo and branches" parameter in the git-push-on-fips-branches.yaml file to ensure it works as intended.

@ti-chi-bot ti-chi-bot bot added the size/S label Jun 25, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 25, 2024
@wuhuizuo
Copy link
Collaborator Author

why: we need to upgrade the builder's OS to support new C++ version.

@ti-chi-bot ti-chi-bot bot merged commit eb260cc into main Jun 25, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/disable-tiflash-mac-builds branch June 25, 2024 09:46
ti-chi-bot bot pushed a commit that referenced this pull request Jul 1, 2024
…arget builds" (#1172)

Reverts #1168


all mac machines is updated with new cmake version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant