-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apps/prod/tekton/configs/triggers): disable tiflash mac target builds #1168
Conversation
…ilds Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Based on the pull request, it looks like the changes are focused on disabling tiflash mac target builds. The changes made were altering the value of the "filter on repo and branches" parameter in the git-push-on-fips-branches.yaml file, and commenting out the ref line in the git-push.yaml file. However, there are a few potential problems with this pull request. First, it's not clear why tiflash mac target builds need to be disabled. Secondly, commenting out the ref line in the git-push.yaml file might have unintended consequences that the submitter hasn't considered. Finally, the new value of the "filter on repo and branches" parameter in the git-push-on-fips-branches.yaml file is not formatted correctly. To fix these issues, the submitter needs to add a more detailed explanation for why tiflash mac target builds need to be disabled. They should also consider whether commenting out the ref line in the git-push.yaml file is the best solution, or if there is another way to achieve the desired result. Finally, they should fix the formatting of the new value of the "filter on repo and branches" parameter in the git-push-on-fips-branches.yaml file to ensure it works as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
why: we need to upgrade the builder's OS to support new C++ version. |
Signed-off-by: wuhuizuo wuhuizuo@126.com