Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pingcap/tidb-operator): add trigger for branches and tags #1175

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Jul 2, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind July 2, 2024 08:03
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Jul 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that the changes are related to adding triggers for branches and tags in the pingcap/tidb-operator repository.

The actual code changes include adding two new files: git-create-tag.yaml and git-push.yaml for the pingcap/tidb-operator repository and updating the kustomization.yaml file to include these new files.

Overall, the changes seem reasonable, but there are a few potential problems:

  • There is no explanation in the PR description about why these triggers are being added or what problem they are solving. It may be useful to add this information to the PR description for context.
  • In git-create-tag.yaml and git-push.yaml, there are hardcoded values for builder-resources-memory and builder-resources-cpu. These values may not be appropriate for all environments and could cause issues if not adjusted.
  • In git-push.yaml, the filter for branches only includes master and any release- branches. Other branches may also need to be included, depending on the project's branching strategy.

To fix these issues, the PR author could:

  • Add to the PR description a brief explanation of why these triggers are being added and what problem they are solving.
  • In git-create-tag.yaml and git-push.yaml, use variables or parameters to allow the values for builder-resources-memory and builder-resources-cpu to be configured externally.
  • In git-push.yaml, update the filter for branches to include all branches that should trigger a build.

@ti-chi-bot ti-chi-bot bot added the size/M label Jul 2, 2024
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Jul 2, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9277073 into main Jul 2, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/support-tidb-operator branch July 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant