fix(apps/prod/tekton/configs/triggers/triggers): fix binding for triggers

[wuhuizuo]

User description

Signed-off-by: wuhuizuo wuhuizuo@126.com

---

PR Type

Bug fix

---

Description

• Corrected the parameter name from force-builder-image to builder-image in the following trigger configurations:
  • fake-github-branch-push
  • fake-github-pr
  • fake-github-tag-create

---

Changes walkthrough 📝

Relevant files

Bug fix

fake-github-branch-push.yaml Fix parameter name in fake-github-branch-push trigger configuration apps/prod/tekton/configs/triggers/triggers/_/fake-github/fake-github-branch-push.yaml Corrected the parameter name from force-builder-image to builder-image. +1/-1      fake-github-pr.yaml Fix parameter name in fake-github-pr trigger configuration apps/prod/tekton/configs/triggers/triggers/_/fake-github/fake-github-pr.yaml Corrected the parameter name from force-builder-image to builder-image. +1/-1      fake-github-tag-create.yaml Fix parameter name in fake-github-tag-create trigger configuration apps/prod/tekton/configs/triggers/triggers/_/fake-github/fake-github-tag-create.yaml Corrected the parameter name from force-builder-image to builder-image. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the author is fixing a binding issue for triggers. Looking at the diff, it seems that the author is changing the binding of $(extensions.custom-params.force-builder-image) to $(extensions.custom-params.builder-image) in three YAML files related to triggers.

There don't seem to be any potential problems with this change as it is a simple binding fix. However, it is important to check if the change might affect any other parts of the codebase that rely on $(extensions.custom-params.force-builder-image).

As for fixing suggestions, it would be good for the reviewer to test the changes locally and verify that the fix works as expected. Additionally, the reviewer might want to double-check if any other files in the codebase are affected by this binding change. Finally, the reviewer could suggest adding a brief explanation to the pull request description to give more context to other team members who might review the change in the future.

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Possible Typo: The PR description and the actual changes in the YAML files do not match. The description mentions changing force-builder-image to builder-image, but the diff shows that only the value was changed to reference builder-image instead of changing the key itself. This might not resolve the issue if the key name was supposed to be corrected.

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Verify that the new parameter is correctly defined and used to avoid runtime errors Ensure that the new parameter force-builder-image is correctly referenced and used in the template. If $(extensions.custom-params.builder-image) is not defined or has a different name, it could lead to runtime errors. apps/prod/tekton/configs/triggers/triggers/_/fake-github/fake-github-branch-push.yaml [69] -- { name: force-builder-image, value: $(extensions.custom-params.builder-image) } +- { name: force-builder-image, value: $(extensions.custom-params.builder-image) } # Ensure this parameter is correctly defined Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies a potential issue with the parameter reference change in the YAML configuration. Ensuring correct parameter references is crucial to avoid runtime errors, making this a valuable suggestion. However, the suggestion does not verify if the parameter is actually undefined or misnamed, which would have made it more actionable.	7

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apps/prod/OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment