Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ghcr.io/pingcap-qe/cd/utils/release docker tag to v20240325-60-gb6f8928 #1181

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Jul 9, 2024

User description

Signed-off-by: wuhuizuo wuhuizuo@126.com


PR Type

dependencies


Description

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release to v20240325-60-gb6f8928 across multiple Tekton pipeline and task configuration files.
  • Ensured consistency in the Docker image version used in various tasks including pingcap-release-ga, gen-build-binaries-scripts, gen-build-images-scripts, multi-arch-image-collect, pingcap-auto-add-image-major-tag, pingcap-build-binaries-darwin, pingcap-build-binaries, pingcap-build-images, pingcap-compose-offline-pkgs, pingcap-get-builder-image, publish-tiup-from-oci-artifact, create-pr-to-add-release-anchor-commit, and create-pr-to-bump-tikv-version.

Changes walkthrough 📝

Relevant files
Dependencies
13 files
pingcap-release-ga.yaml
Update Docker image tag in pingcap-release-ga pipeline     

apps/prod/tekton/configs/pipelines/pingcap-release-ga.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +2/-2     
    gen-build-binaries-scripts.yaml
    Update Docker image tag in gen-build-binaries-scripts task

    apps/prod/tekton/configs/tasks/gen-build-binaries-scripts.yaml

  • Updated the default Docker image tag for
    ghcr.io/pingcap-qe/cd/utils/release to v20240325-60-gb6f8928.
  • +1/-1     
    gen-build-images-scripts.yaml
    Update Docker image tag in gen-build-images-scripts task 

    apps/prod/tekton/configs/tasks/gen-build-images-scripts.yaml

  • Updated the default Docker image tag for
    ghcr.io/pingcap-qe/cd/utils/release to v20240325-60-gb6f8928.
  • +1/-1     
    multi-arch-image-collect.yaml
    Update Docker image tag in multi-arch-image-collect task 

    apps/prod/tekton/configs/tasks/multi-arch-image-collect.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +1/-1     
    pingcap-auto-add-image-major-tag.yaml
    Update Docker image tag in pingcap-auto-add-image-major-tag task

    apps/prod/tekton/configs/tasks/pingcap-auto-add-image-major-tag.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +1/-1     
    pingcap-build-binaries-darwin.yaml
    Update Docker image tag in pingcap-build-binaries-darwin task

    apps/prod/tekton/configs/tasks/pingcap-build-binaries-darwin.yaml

  • Updated the default Docker image tag for
    ghcr.io/pingcap-qe/cd/utils/release to v20240325-60-gb6f8928.
  • +4/-4     
    pingcap-build-binaries.yaml
    Update Docker image tag in pingcap-build-binaries task     

    apps/prod/tekton/configs/tasks/pingcap-build-binaries.yaml

  • Updated the default Docker image tag for
    ghcr.io/pingcap-qe/cd/utils/release to v20240325-60-gb6f8928.
  • +3/-3     
    pingcap-build-images.yaml
    Update Docker image tag in pingcap-build-images task         

    apps/prod/tekton/configs/tasks/pingcap-build-images.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +2/-2     
    pingcap-compose-offline-pkgs.yaml
    Update Docker image tag in pingcap-compose-offline-pkgs task

    apps/prod/tekton/configs/tasks/pingcap-compose-offline-pkgs.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +1/-1     
    pingcap-get-builder-image.yaml
    Update Docker image tag in pingcap-get-builder-image task

    apps/prod/tekton/configs/tasks/pingcap-get-builder-image.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +1/-1     
    publish-tiup-from-oci-artifact.yaml
    Update Docker image tag in publish-tiup-from-oci-artifact task

    apps/prod/tekton/configs/tasks/publish-tiup-from-oci-artifact.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +2/-2     
    create-pr-to-add-release-anchor-commit.yaml
    Update Docker image tag in create-pr-to-add-release-anchor-commit task

    apps/prod/tekton/configs/tasks/release/create-pr-to-add-release-anchor-commit.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +1/-1     
    create-pr-to-bump-tikv-version.yaml
    Update Docker image tag in create-pr-to-bump-tikv-version task

    apps/prod/tekton/configs/tasks/release/create-pr-to-bump-tikv-version.yaml

  • Updated the Docker image tag for ghcr.io/pingcap-qe/cd/utils/release
    to v20240325-60-gb6f8928.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    … v20240325-60-gb6f8928
    
    Signed-off-by: wuhuizuo <wuhuizuo@126.com>
    @ti-chi-bot ti-chi-bot bot requested a review from purelind July 9, 2024 12:19
    @ti-chi-bot ti-chi-bot bot added the area/apps label Jul 9, 2024
    Copy link
    Contributor

    ti-chi-bot bot commented Jul 9, 2024

    I have already done a preliminary review for you, and I hope to help you do a better job.

    This pull request updates the docker tag for multiple images used in the pipeline to v20240325-60-gb6f8928. The changes seem straightforward and there are no red flags. The only potential issue is that we do not have any information on why this update is necessary and what it aims to achieve.

    To improve the readability of the pull request, it would be helpful to have some comments added to the code changes explaining the reason behind the update. Additionally, the pull request description is empty, so it would be good to have some information there as well.

    Overall, the changes look fine, and there are no specific suggestions for improvement.

    @ti-chi-bot ti-chi-bot bot added env/prod will deploy on the main product cluster size/M labels Jul 9, 2024
    @wuhuizuo
    Copy link
    Collaborator Author

    wuhuizuo commented Jul 9, 2024

    /approve

    Copy link
    Contributor

    ti-chi-bot bot commented Jul 9, 2024

    [APPROVALNOTIFIER] This PR is APPROVED

    This pull-request has been approved by: wuhuizuo

    The full list of commands accepted by this bot can be found here.

    The pull request process is described here

    Needs approval from an approver in each of these files:

    Approvers can indicate their approval by writing /approve in a comment
    Approvers can cancel approval by writing /approve cancel in a comment

    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Use a variable for the image version to simplify future updates

    Consider using a variable for the image version to ensure consistency and ease
    future updates. This can be defined at the top of the YAML file and referenced
    wherever needed.

    apps/prod/tekton/configs/pipelines/pingcap-release-ga.yaml [31]

    -image: ghcr.io/pingcap-qe/cd/utils/release:v20240325-60-gb6f8928
    +image: ${IMAGE_VERSION}
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Using a variable for the image version improves maintainability and consistency, making future updates easier and reducing the risk of errors.

    8
    Use a variable instead of hardcoding the image version to enhance maintainability

    Replace the direct image version with a variable to facilitate easier updates and
    ensure consistency across multiple files.

    apps/prod/tekton/configs/tasks/pingcap-build-binaries-darwin.yaml [41]

    -default: ghcr.io/pingcap-qe/cd/utils/release:v20240325-60-gb6f8928
    +default: ${BUILDER_IMAGE}
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Replacing hardcoded values with variables improves maintainability and consistency across multiple files, making updates easier.

    8
    Best practice
    Replace hardcoded image version with a variable for easier management

    To avoid hardcoding the image version multiple times, define a global variable at
    the beginning of the file and reference it in the task.

    apps/prod/tekton/configs/tasks/gen-build-binaries-scripts.yaml [29]

    -default: ghcr.io/pingcap-qe/cd/utils/release:v20240325-60-gb6f8928
    +default: ${DEFAULT_IMAGE}
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Defining a global variable for the image version enhances maintainability and reduces redundancy, which is a best practice in configuration management.

    8
    Replace hardcoded image version with a variable to streamline updates

    Implement a variable for the image version at the start of your YAML configuration
    to avoid repetitive hardcoding and simplify updates.

    apps/prod/tekton/configs/tasks/pingcap-build-images.yaml [47]

    -image: ghcr.io/pingcap-qe/cd/utils/release:v20240325-60-gb6f8928
    +image: ${RELEASE_IMAGE}
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Implementing a variable for the image version reduces redundancy and simplifies updates, following best practices for configuration management.

    8

    @ti-chi-bot ti-chi-bot bot merged commit e75e2c4 into main Jul 9, 2024
    4 checks passed
    @ti-chi-bot ti-chi-bot bot deleted the fix/bump-cd-util-relase-iamge branch July 9, 2024 12:33
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant