chore(apps/prod/tekton/configs/triggers): increase pipeline run timeout to 3h

[wuhuizuo]

User description

avoid timeout on low performance mac machines.

Signed-off-by: wuhuizuo wuhuizuo@126.com

---

PR Type

Enhancement

---

Description

• Increased the pipeline run timeout to 3 hours for tiflash and tikv components to avoid timeouts on low-performance Mac machines.

---

Changes walkthrough 📝

Relevant files

Enhancement

git-push.yaml Increase pipeline run timeout for tiflash to 3 hours          apps/prod/tekton/configs/triggers/triggers/pingcap/tiflash/git-push.yaml Increased the pipeline run timeout from 2 hours to 3 hours. +1/-1      git-push.yaml Increase pipeline run timeout for tikv to 3 hours                apps/prod/tekton/configs/triggers/triggers/tikv/tikv/git-push.yaml Increased the pipeline run timeout from 2 hours 30 minutes to 3 hours. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request increases the pipeline run timeout from 2 hours to 3 hours for the triggers in apps/prod/tekton/configs/triggers/triggers/pingcap/tiflash/git-push.yaml and apps/prod/tekton/configs/triggers/triggers/tikv/tikv/git-push.yaml. The reason for this change is to avoid timeout on low-performance Mac machines.

There are no potential problems with this change. However, it is important to note that increasing the timeout may result in longer wait times for builds to complete.

One suggestion to improve the pull request is to provide more context. It would be helpful to know how the low-performance Mac machines were affecting the pipeline and why the timeout needed to be increased.

Another suggestion is to consider alternative solutions to the timeout problem, such as optimizing the pipeline or upgrading the machine's performance.

Overall, this pull request seems reasonable and can be merged.

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

[wuhuizuo]

/approve

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Standardize the timeout format to improve consistency and clarity Consider using a consistent time format for the timeout value. If other configurations use a specific format (like ISO 8601), it might be beneficial to align with that for consistency and clarity. apps/prod/tekton/configs/triggers/triggers/pingcap/tiflash/git-push.yaml [26] -- { name: timeout, value: 3h } +- { name: timeout, value: "PT3H" } Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion improves consistency and clarity by using a standardized time format, which is beneficial for maintaining uniformity across configurations.	8
Possible issue	Adjust the timeout to a more conservative increment to help identify performance bottlenecks Ensure that the timeout value is appropriate considering the previous value and the tasks performed. A significant increase might mask underlying performance issues. apps/prod/tekton/configs/triggers/triggers/tikv/tikv/git-push.yaml [30] -- { name: timeout, value: 3h } +- { name: timeout, value: "2h45m" } Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion is valid as it encourages a more conservative increment in timeout, which can help in identifying underlying performance issues. However, it assumes that the previous timeout was adequate, which may not always be the case.	7

[purelind]

/lgtm

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apps/prod/OWNERS [purelind,wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-11 06:05:49.430927638 +0000 UTC m=+510446.666161748: ☑️ agreed by purelind.