Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton/configs/triggers): enable release branch to trigger builds #1187

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

wuhuizuo
Copy link
Collaborator

add releae-6.0~6.6

Signed-off-by: wuhuizuo wuhuizuo@126.com

…gger builds

add releae-6.0~6.6

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind July 29, 2024 10:06
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to enabling release branches to trigger builds. Looking at the diff, it appears that the changes are adding new release branches (6.0~6.6) to trigger builds and updating the regular expressions in the git-push.yaml files for various components to include these new release branches.

There don't seem to be any obvious potential problems with these changes, but it would be good to confirm that the regular expressions for the git-push.yaml files are correct and will capture all the necessary branches. It would also be a good idea to test the changes to ensure that the new release branches are triggering builds as expected.

One suggestion for improvement would be to add some documentation to the code or the pull request description that explains how to modify the regular expressions in the git-push.yaml files in the future if new release branches are added.

@ti-chi-bot ti-chi-bot bot added the size/M label Jul 29, 2024
@wuhuizuo
Copy link
Collaborator Author

manually tested.

@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here.

Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit c93c06f into main Jul 29, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/release-6.5-build-support branch July 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant