Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(apps/prod): add triggermesh service" #1188

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Ref #856

Signed-off-by: wuhuizuo wuhuizuo@126.com

Ref #856

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind July 30, 2024 16:25
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster size/XXL labels Jul 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request titled "Revert 'chore(apps/prod): add triggermesh service'" is proposing to revert the changes made in a previous commit where the 'triggermesh' service was added to the 'apps/prod' directory of the project.

Key Changes:

  1. The reference to 'triggermesh' has been removed from the resources list in the 'kustomization.yaml' file.
  2. The 'triggermesh' directory and all its contents (including 'kustomization.yaml', 'triggermesh.yaml', and 'triggermesh-crds.yaml') have been deleted.
  3. The cluster roles, service accounts, webhooks, and deployment configurations for 'triggermesh' have been removed.

Potential Problems:

  1. By removing 'triggermesh', any services or applications depending on it will fail.
  2. If 'triggermesh' was added as part of a feature or improvement, then this change could potentially remove that feature or cause regressions.
  3. The deletion of 'triggermesh' related cluster roles and service accounts could affect the permissions and access control in the Kubernetes cluster.

Suggested Fixes:

  1. Ensure that 'triggermesh' is not a dependency for other services or applications. If it is, consider alternative solutions or ensure these services have a fallback.
  2. Test all features and improvements that included the addition of 'triggermesh' to ensure there are no regressions.
  3. Review the impact of removing the 'triggermesh' related cluster roles and service accounts on the overall Kubernetes cluster's security and access control.

@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here.

Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit c688e88 into main Jul 30, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/uninstall-trigger branch July 30, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant