Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/prod/tekton/configs/triggers): limit oci artifacts push event resource url (#1223) #1226

Merged

Conversation

wuhuizuo
Copy link
Collaborator

limit it to special new harbor instance.

Signed-off-by: wuhuizuo wuhuizuo@126.com

…ent resource url (#1223)

limit it to special new harbor instance.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind August 15, 2024 03:31
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Aug 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the provided information, it seems that the pull request is related to Tekton trigger configuration for OCI artifact push event.

The key change in this pull request is that the resource_url property of the event should match a specific value (hub-mig.pingcap.net/) instead of the previous value (hub.pingcap.net/). This change aims to limit the events to a specific new Harbor instance.

There don't seem to be any potential problems with this pull request, as the change is straightforward and doesn't add any new functionality.

However, here are some suggestions for improvement:

  • Add more context to the pull request description, such as why this change is necessary and how it impacts the system.
  • Consider adding some test cases to ensure that the trigger configuration works correctly with the new resource_url value.
  • Consider adding some documentation for the new Harbor instance and how to use it in the trigger configuration.

@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 15, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1f72403 into main Aug 15, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/migrate-tiup-publish-listener-to-another-harbor branch August 15, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant