Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/prod/tekton/configs): increase timeout for tiup publish #1232

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

@ti-chi-bot ti-chi-bot bot requested a review from purelind August 27, 2024 06:11
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Aug 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change is an increase in the timeout duration for two different tasks from 1 hour to 2 hours. The tasks are "wait" in pingcap-release-ga.yaml and "publish-tiup-from-oci-artifact" in push-oci-artifact-to-tiup.yaml.

The changes seem reasonable and there are no apparent issues with them. However, it is worth noting that increasing timeouts may not always be the best solution for resolving issues. It is better to investigate why the tasks are taking longer than expected and optimize them if possible.

As for fixing suggestions, if the timeouts were increased due to known issues, the pull request description could be updated to provide more context on the reasons for the change. Additionally, it would be helpful to have some documentation on the expected duration of these tasks to help avoid future issues related to timeouts.

Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2e80be9 into main Aug 27, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/increase-tiup-publish-timeout branch August 27, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant