Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pingcap/tidb-operator): support wide version tag #1233

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind August 27, 2024 10:46
@ti-chi-bot ti-chi-bot bot added the area/apps label Aug 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the pull request, it seems that the change is related to supporting wide version tags in the pingcap/tidb-operator repository. Specifically, the regular expression used to match version tags (^v[0-9]+[.][0-9]+[.][0-9]+$) has been updated to also support tags with additional information after the version number (^v[0-9]+[.][0-9]+[.][0-9]+(-.+)?$).

As for potential problems, it's difficult to tell without more context. However, if this regular expression is used to automatically create tags based on certain events (such as a new release), there could be issues if the tag format changes unexpectedly.

To address this potential issue, one suggestion would be to add some validation or confirmation steps before creating a new tag. For example, a script could be run to confirm that the tag format is correct before creating the tag.

Overall, the change seems straightforward and should not cause any issues as long as the new regular expression is used consistently.

@ti-chi-bot ti-chi-bot bot added env/prod will deploy on the main product cluster size/XS labels Aug 27, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9877383 into main Aug 27, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/support-wide-version-tag-for-tidb-operator branch August 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant