Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/jenkins-beta): remove useless post step #659

Merged

Conversation

purelind
Copy link
Contributor

@purelind purelind commented Aug 2, 2023

remove useless post.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and wuhuizuo August 2, 2023 04:25
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Summary

This pull request adds some ns config to the Jenkins Beta application.

Changes Made

  • Added namespace.yaml to post/cd/ and post/ti-pipeline/ directories.
  • Added kustomization.yaml to post/cd/ and post/ti-pipeline/ directories.

Potential Problems

No potential problems found.

Fixing Suggestions

No fixing suggestions needed.

@ti-chi-bot ti-chi-bot bot added the size/M label Aug 2, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, the changes made in this pull request are adding ns configs to the jenkins-beta app. Specifically, two files (rbac.yaml and kustomization.yaml) have been deleted from the post/_base directory.

It is difficult to ascertain if there are any potential problems with the changes made in this pull request as there is no context provided. However, it is possible that deleting files from the post/_base directory could have unintended consequences if they are needed for other parts of the application.

A possible suggestion for fixing this pull request is to provide more context on why these files were deleted and what impact this will have on the jenkins-beta application. Additionally, it would be helpful to provide information on any testing that was done to ensure that the changes made did not cause any issues.

@purelind purelind changed the title fix(apps/prod/jenkins-beta): add ns conf on post step fix(apps/prod/jenkins-beta): remove useless post step Aug 2, 2023
@wuhuizuo
Copy link
Collaborator

wuhuizuo commented Aug 2, 2023

Also you should delete the post.yaml and update the kustomzation file @purelind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
The pull request removes a useless post step from the Jenkins-beta application. In the diff, the post.yaml file and its dependencies are deleted, indicating that these files are no longer needed. The change seems straightforward and does not introduce any new code.

No potential problems have been identified in this pull request.

Suggestion: The pull request looks good as it is, no suggestions are needed.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 2, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 06:30:50.732486991 +0000 UTC m=+253334.674835517: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 64d73fb into PingCAP-QE:main Aug 2, 2023
3 checks passed
@purelind purelind deleted the purelind/fix-jenkins-beta-post-conf branch August 2, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants