feature(apps/prod/tekton/configs): git clone with git-cdn service

[wuhuizuo]

enable:

• pingcap/advanced-statefulset
• pingcap/tiflash
• pingcap/tiflow
• tikv/tikv
• tikv/pd

Signed-off-by: wuhuizuo wuhuizuo@126.com

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review: feature(apps/prod/tekton/configs): git clone with git-cdn

Summary

The PR adds a new feature to fetch git repositories using git-cdn. It updates the build.yaml file for different pipelines.

Potential Problems

• The commit message and description are not informative enough. It would be better if the author provides more information about the changes.
• The added secret git-credentials-basic is not mentioned in the PR description. It would be better if the author provides more information about it.
• The added feature may cause security issues if the git-cdn endpoint is compromised. It would be better to provide more information about the security risks and the measures taken to mitigate them.

Fixing Suggestions

• The author should provide more informative commit message and description about the changes.
• The author should provide more information about the added secret and its usage.
• The author should provide more information about the security risks and the measures taken to mitigate them.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Review for "feature(apps/prod/tekton/configs): git clone with git-cdn" Pull Request

Summary

This pull request adds the git-basic-auth secret to fetch private repositories using git-cdn for five different projects.

Potential Problems

• There is no explanation on what git-cdn is and why it should be used instead of the default git clone command.
• The changes in this pull request are only adding one secret to each project. It is unclear if this is the only change required to use git-cdn.
• There is no explanation on how to set up the git-credentials-basic secret.
• There is no explanation on how to verify if the change was successful or not.
• The pull request description is too short. It would be helpful to have more information about why this change is being made.

Fixing Suggestions

• Add a brief explanation about git-cdn and how it differs from the default git clone command.
• Clarify if there are any additional changes required to use git-cdn.
• Add instructions on how to set up the git-credentials-basic secret.
• Add instructions on how to test if the change was successful or not.
• Add more information to the pull request description to provide context on why this change is being made.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apps/prod/OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment