feat(apps/prod/tekton/setup): enable cloudevent emit and add sink url

[wuhuizuo]

Notice: currently we need update the config map tekton-pipelines/feature-flags manually because of the operator not support the congfiguration before v0.63.0.
Signed-off-by: wuhuizuo wuhuizuo@126.com

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Summary

The pull request adds the ability to enable cloudevent emit and add sink url to the operator-config.yaml file.

Potential Problems

• The pull request description mentions that the config map tekton-pipelines/feature-flags needs to be updated manually because the operator does not support the configuration before v0.63.0. It is not clear whether this has been addressed in the pull request or if it is still a problem.
• The sink URL is hardcoded in the yaml file. It is recommended to use environment variables to allow for easier configuration changes in the future.

Fix Suggestions

• If the problem with the config map is still present, it should be addressed in the pull request and documented in the description.
• Use environment variables in place of the hardcoded URL.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the provided information, it seems that the pull request aims to add a new feature to the tekton-pipelines/feature-flags config map, namely to enable the emission of cloudevents and add a sink URL.

The key changes in the code are the addition of the send-cloudevents-for-runs: true flag, which enables the emission of cloudevents for pipeline runs, and the default-cloud-events-sink: http://cloudevents-server.apps.svc/events field, which sets the URL of the sink for the emitted cloudevents.

One potential problem with the pull request is that it mentions that the configuration map needs to be updated manually, which might be error-prone and could lead to unexpected behavior. A suggestion for fixing this issue would be to automate the update of the configuration map through a script or a webhook.

Another potential problem is that the sink URL is hard-coded in the configuration file, which might not be flexible enough in some cases. A suggestion for fixing this issue would be to make the sink URL configurable through environment variables or command-line arguments.

Overall, the pull request seems to add a useful feature to the tekton-pipelines/feature-flags config map, but some improvements could be made to make the configuration more robust and flexible.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apps/prod/OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment