fix: pvc pending

[jayl1e]

Why:

• ceph-filesystem is replaced by nfs
• move to jenkins-cd dir

Close: #655

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Review for "fix: pvc pending"

Summary

This pull request replaces the storage class from ceph-filesystem to nfs and moves the pvc.yaml file from apps/prod/ccache-pvc/base to apps/prod/jenkins/post/cd.

Potential Problems

There are no major potential problems with this pull request. However, the description could be clearer as to why the storage class is being changed. Additionally, it might be useful to explain why pvc.yaml is being moved to a different directory.

Suggestions

• Clarify the reason for changing the storage class from ceph-filesystem to nfs in the description.
• Provide more context around why the pvc.yaml file is being moved to a different directory in the description.
• Consider adding comments to the pvc.yaml file to explain the purpose of each PVC.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Summary

This PR aims to replace ceph-filesystem with nfs and move to the jenkins-cd directory. It renames the ccache-pvc directory to pvc and updates the kustomization.yaml and pvc.yaml files in the pvc directory.

Changes Made

• Replaced ceph-filesystem with nfs.
• Moved to jenkins-cd directory.
• Renamed ccache-pvc directory to pvc.
• Updated kustomization.yaml and pvc.yaml files in the pvc directory.

Potential Problems

• There may be other parts of the codebase that rely on ceph-filesystem that could be affected by this change. It would be important to ensure that all other areas of the codebase that use this storageClassName are updated accordingly.
• It is unclear if there are any other changes or updates made to the codebase beyond what is shown in the diff. If there are additional changes made, it would be important to ensure they do not introduce any new bugs or issues.

Suggestions

• Ensure that all other areas of the codebase that use ceph-filesystem are updated accordingly.
• Test the updated codebase thoroughly to ensure there are no new bugs or issues introduced.
• If there are any additional changes made to the codebase beyond what is shown in the diff, ensure they do not introduce any new bugs or issues.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Review of "fix: pvc pending"

Summary

This pull request replaces the usage of ceph-filesystem with nfs and moves some files to a different directory.

Potential Problems

Based on the diff, there are no significant problems in this pull request.

Fixing Suggestions

No fixing suggestions are necessary as the changes look good.

Overall

This is a simple and straightforward pull request that makes sensible changes to the codebase. It should be merged as soon as possible.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Review of the GitHub pull request

Summary

This pull request deletes the pvc.yaml file and adds a new pvc.yaml file in the jenkins-cd directory. The new pvc.yaml file contains new PersistentVolumeClaims with a new storage class nfs. The changes have been made to improve the functionality of the system.

Potential Problems

There are no potential problems with the changes being made in this pull request.

Fixing Suggestions

There are no fixing suggestions required for this pull request. The changes made in this pull request are good and can be merged.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apps/prod/OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-12-19 10:00:20.823467124 +0000 UTC m=+955111.860694051: ☑️ agreed by wuhuizuo.